Skip to content

De-privatize timezone funcs #17502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 13, 2017
Merged

Conversation

jbrockmendel
Copy link
Member

See discussion in #17497

  • closes #xxxx
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@jreback jreback added Compat pandas objects compatability with Numpy or Python functions Timezones Timezone data dtype labels Sep 13, 2017
@jreback
Copy link
Contributor

jreback commented Sep 13, 2017

I think index.pyx needs a mod

@codecov
Copy link

codecov bot commented Sep 13, 2017

Codecov Report

Merging #17502 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17502      +/-   ##
==========================================
- Coverage   91.18%   91.16%   -0.02%     
==========================================
  Files         163      163              
  Lines       49543    49543              
==========================================
- Hits        45177    45168       -9     
- Misses       4366     4375       +9
Flag Coverage Δ
#multiple 88.95% <ø> (ø) ⬆️
#single 40.21% <ø> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.77% <0%> (-0.1%) ⬇️
pandas/core/generic.py 91.98% <0%> (ø) ⬆️
pandas/core/strings.py 98.46% <0%> (ø) ⬆️
pandas/core/indexes/category.py 98.54% <0%> (ø) ⬆️
pandas/core/sparse/series.py 95.09% <0%> (ø) ⬆️
pandas/io/stata.py 93.66% <0%> (ø) ⬆️
pandas/core/reshape/reshape.py 99.29% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83436af...0ddd2ef. Read the comment docs.

@codecov
Copy link

codecov bot commented Sep 13, 2017

Codecov Report

Merging #17502 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17502      +/-   ##
==========================================
- Coverage   91.18%   91.16%   -0.02%     
==========================================
  Files         163      163              
  Lines       49543    49543              
==========================================
- Hits        45177    45168       -9     
- Misses       4366     4375       +9
Flag Coverage Δ
#multiple 88.95% <ø> (ø) ⬆️
#single 40.21% <ø> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.77% <0%> (-0.1%) ⬇️
pandas/core/reshape/reshape.py 99.29% <0%> (ø) ⬆️
pandas/core/generic.py 91.98% <0%> (ø) ⬆️
pandas/core/sparse/series.py 95.09% <0%> (ø) ⬆️
pandas/core/strings.py 98.46% <0%> (ø) ⬆️
pandas/core/indexes/category.py 98.54% <0%> (ø) ⬆️
pandas/io/stata.py 93.66% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83436af...0ddd2ef. Read the comment docs.

@jreback jreback added this to the 0.21.0 milestone Sep 13, 2017
@jreback jreback merged commit fa557f7 into pandas-dev:master Sep 13, 2017
@jreback
Copy link
Contributor

jreback commented Sep 13, 2017

thanks!

@jbrockmendel jbrockmendel deleted the tslibs-timezones4 branch October 30, 2017 16:24
alanbato pushed a commit to alanbato/pandas that referenced this pull request Nov 10, 2017
No-Stream pushed a commit to No-Stream/pandas that referenced this pull request Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compat pandas objects compatability with Numpy or Python functions Timezones Timezone data dtype
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants